PR for educational purpose#712
Closed
Valentin-Laurent wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new utility function to validate that a given input is a pandas DataFrame along with corresponding tests to ensure its correct behavior.
- Added the function check_if_X_dataframe in mapie/utils.py.
- Added new unit tests in tests_v1/test_unit/test_utils.py for verifying various input types.
- Introduced an import for pandas in the test file.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests_v1/test_unit/test_utils.py | Added unit tests for check_if_X_dataframe and a pandas import. |
| mapie/utils.py | Added check_if_X_dataframe to validate that X is a pandas DataFrame. |
Comments suppressed due to low confidence (1)
tests_v1/test_unit/test_utils.py:278
- The use of 'np.array' suggests the numpy module is required, but there is no import statement for numpy in this diff. Please add 'import numpy as np' to ensure the tests run correctly.
np.array([[1, 2], [3, 4]]),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.